Differential D21723
Make corrections to the "arc amend" workflow in Mercurial repositories to be compatible with PHP 5+ Authored by cspeckmim on Sep 16 2021, 6:54 PM. Tags None Referenced Files
Subscribers Tokens
Details
Refs T13665 In the update to D21716 the str_starts_with function was added which is only available in PHP 8. This changes it to use strncmp() which is compatible back to PHP 4. Additionally fixed running into an error when trying to run arc amend on a commit which already matches the content known in Phabricator. Mercurial throws an error when running amend without file changes and using the exact same commit message it already has. I created a commit and revision then used hg amend -e to modify the commit message locally. I ran arc inspect --explore -- 'commit(674492bb460)' and verified it matched the appropriate commit, to verify the substring matching works properly.
Diff Detail
Event TimelineComment Actions The second baby has arrived so I have about 17 seconds per day to look at my computer nowadays, but I think it would also be reasonable to backfill str_starts_with() if you run into more of this -- the strncmp() syntax has always felt pretty hard to read to me. You can do that in PHP like this: if (!function_exists('str_starts_with')) {
function str_starts_with(...) {
}
}Comment Actions
 
I didn't realize functions could be conditionally defined like that - I played around with it testing different versions and it looks pretty straightforward. I'll keep that in mind for future changes. |