Page MenuHomePhabricator

Correct a parameter order swap in "diffusion.historyquery" for Mercurial
ClosedPublic

Authored by epriestley on Sep 5 2021, 12:47 AM.
Tags
None
Referenced Files
F15455616: D21722.diff
Sun, Mar 30, 3:38 AM
F15429192: D21722.id51760.diff
Mon, Mar 24, 1:06 AM
F15426102: D21722.id51760.diff
Mar 23 2025, 7:07 AM
F15409464: D21722.id51760.diff
Mar 19 2025, 4:33 AM
F15402580: D21722.id.diff
Mar 17 2025, 11:05 PM
F15392391: D21722.diff
Mar 15 2025, 2:54 PM
F15338866: D21722.diff
Mar 9 2025, 1:11 PM
F15334344: D21722.diff
Mar 8 2025, 8:24 AM
Subscribers
None

Details

Summary

Ref T13666. See T13666#256253. The order of these parameters is incorrect (introduced in D18817, which was trying to turn the revset "A or B" into "B or A"), but when "commit" is the single head of "branch" (which is common), the revset is functionally equivalent.

Test Plan

An easy reproduction case is to make a "diffusion.historyquery" call manually against a Mercurial repository, with a valid "branch" name and some non-head "commit".

  • Before patch, queried "head^" (by commit hash, not by symbol) of "default" and got "head" too (wrong).
  • Applied patch to secure001.phacility.net (my local hg web environment is iffy right now).
  • Re-ran the same query, saw "head^" as the first result rather than "head" (all hashes rather than symbols, as above), which is desired.

Diff Detail

Repository
rP Phabricator
Branch
hg1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25556
Build 35344: Run Core Tests
Build 35343: arc lint + arc unit