Page MenuHomePhabricator

Fix searching legalpad documents by contributors
ClosedPublic

Authored by cspeckmim on Sep 4 2021, 5:48 PM.
Tags
None
Referenced Files
F15414252: D21719.diff
Wed, Mar 19, 11:42 PM
F15411332: D21719.diff
Wed, Mar 19, 9:00 AM
F15411272: D21719.diff
Wed, Mar 19, 8:57 AM
F15411208: D21719.diff
Wed, Mar 19, 8:54 AM
F15411128: D21719.diff
Wed, Mar 19, 8:51 AM
F15411005: D21719.diff
Wed, Mar 19, 8:46 AM
F15410932: D21719.diff
Wed, Mar 19, 8:43 AM
F15410091: D21719.diff
Wed, Mar 19, 6:46 AM
Subscribers

Details

Summary

Found in a change submitted to Phorge (https://we.phorge.it/D25018#inline-231), this fixes a typo in populating search the contributorPHIDs constraint in the Legalpad search engine.

Currently when trying to search legalpad documents by contributor an error is encountered:

Array for %Ls conversion is empty. Query: contributor.dst IN (%Ls)
Test Plan

I searched for legalpad documents based on a contributor and got back correct results.

Diff Detail

Repository
rP Phabricator
Branch
legalpad
Lint
Lint Passed
Unit
Tests Skipped
Build Status
Buildable 25541
Build 35319: Run Core Tests
Build 35318: arc lint + arc unit

Event Timeline

cspeckmim held this revision as a draft.
cspeckmim edited the summary of this revision. (Show Details)
cspeckmim edited the test plan for this revision. (Show Details)

I didn't make a task for this as it's a fairly small change and the reproduction/test case is also fairly simple.

cspeckmim retitled this revision from Fix typo in legalpad search engine to Fix searching legalpad documents by contributors.Sep 4 2021, 11:51 PM
This revision is now accepted and ready to land.Sep 5 2021, 12:17 AM