Page MenuHomePhabricator
Differential D21719

Fix searching legalpad documents by contributors
ClosedPublic
Actions

Authored by cspeckmim on Sep 4 2021, 5:48 PM.
Tags
None
Referenced Files
F13091691: D21719.diff
Thu, Apr 25, 3:09 AM
Unknown Object (File)
Mon, Apr 22, 1:53 AM
Unknown Object (File)
Thu, Apr 11, 10:38 AM
Unknown Object (File)
Sat, Apr 6, 3:28 PM
Unknown Object (File)
Sat, Apr 6, 4:49 AM
Unknown Object (File)
Mar 20 2024, 8:15 PM
Unknown Object (File)
Feb 4 2024, 1:24 AM
Unknown Object (File)
Jan 15 2024, 12:33 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rP3b2868e15553: Fix searching legalpad documents by contributors
Summary

Found in a change submitted to Phorge (https://we.phorge.it/D25018#inline-231), this fixes a typo in populating search the contributorPHIDs constraint in the Legalpad search engine.

Currently when trying to search legalpad documents by contributor an error is encountered:

Array for %Ls conversion is empty. Query: contributor.dst IN (%Ls)
Test Plan

I searched for legalpad documents based on a contributor and got back correct results.

Diff Detail

Repository
rP Phabricator
Branch
legalpad
Lint
Lint Passed
Unit
Tests Skipped
Build Status
Buildable 25541
Build 35319: Run Core Tests
Build 35318: arc lint + arc unit

Event Timeline

cspeckmim created this revision.Sep 4 2021, 5:48 PM
cspeckmim held this revision as a draft.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptSep 4 2021, 5:48 PM
Herald added a subscriber: epriestley. · View Herald Transcript
cspeckmim edited the summary of this revision. (Show Details)Sep 4 2021, 5:49 PM
Harbormaster completed remote builds in B25541: Diff 51743.Sep 4 2021, 5:49 PM
cspeckmim published this revision for review.Sep 4 2021, 11:10 PM
cspeckmim edited the summary of this revision. (Show Details)
cspeckmim edited the test plan for this revision. (Show Details)

I didn't make a task for this as it's a fairly small change and the reproduction/test case is also fairly simple.

cspeckmim retitled this revision from Fix typo in legalpad search engine to Fix searching legalpad documents by contributors.Sep 4 2021, 11:51 PM
epriestley accepted this revision.Sep 5 2021, 12:17 AM

Thanks!

This revision is now accepted and ready to land.Sep 5 2021, 12:17 AM
Herald added a subscriber: Korvin. · View Herald TranscriptSep 5 2021, 12:17 AM
Closed by commit rP3b2868e15553: Fix searching legalpad documents by contributors (authored by cspeckmim). · Explain WhySep 5 2021, 12:37 AM
This revision was automatically updated to reflect the committed changes.
cspeckmim added a commit: rP3b2868e15553: Fix searching legalpad documents by contributors.

Revision Contents
Changeset List

PathSize
src/
applications/
legalpad/
query/
2 lines

Diff 51743

View Options

src/applications/legalpad/query/LegalpadDocumentSearchEngine.php

Loading...
Phabricator · Built by Phacility