Page MenuHomePhabricator
Differential D21689

Modularize HarbormasterBuildTransaction
ClosedPublic
Actions

Authored by epriestley on Jul 15 2021, 9:05 PM.
Tags
None
Referenced Files
F15456444: D21689.diff
Sun, Mar 30, 9:45 AM
F15455571: D21689.id51651.diff
Sun, Mar 30, 3:17 AM
F15445825: D21689.diff
Thu, Mar 27, 4:10 PM
F15441990: D21689.diff
Wed, Mar 26, 8:54 PM
F15438587: D21689.id51702.diff
Wed, Mar 26, 1:47 AM
F15438418: D21689.id.diff
Wed, Mar 26, 12:35 AM
F15427780: D21689.id51651.diff
Sun, Mar 23, 4:00 PM
F15426021: D21689.diff
Sun, Mar 23, 6:51 AM
View All Files
Subscribers
Restricted Owners Package

Details

Reviewers
None
Maniphest Tasks
T13072: Merge Harbormaster BuildCommand into BuildMessage
Commits
rP6dfea0adaddc: Modularize HarbormasterBuildTransaction
Summary

Ref T13072. Update "HarbormasterBuild" to use modern modular transactions.

Test Plan
  • Aborted, restarted, paused, and resumed a build.
  • Used bin/harbormaster restart.
  • Grepped for use of old "::TYPE_COMMAND" constant, didn't find any hits.

Diff Detail

Repository
rP Phabricator
Branch
build6
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/harbormaster/xaction/build/HarbormasterBuildMessageTransaction.php:82XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 25454
Build 35176: Run Core Tests
Build 35175: arc lint + arc unit

Event Timeline

epriestley created this revision.Jul 15 2021, 9:05 PM
Owners added a subscriber: Restricted Owners Package.Jul 15 2021, 9:05 PM
Harbormaster completed remote builds in B25454: Diff 51651.Jul 15 2021, 9:07 PM
epriestley requested review of this revision.Jul 15 2021, 9:07 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jul 21 2021, 9:17 PM
Closed by commit rP6dfea0adaddc: Modularize HarbormasterBuildTransaction (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP6dfea0adaddc: Modularize HarbormasterBuildTransaction.

Revision Contents
Changeset List

Diff 51651

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/harbormaster/editor/HarbormasterBuildTransactionEditor.php

Loading...
View Options

src/applications/harbormaster/engine/HarbormasterBuildEngine.php

Loading...
View Options

src/applications/harbormaster/management/HarbormasterManagementRestartWorkflow.php

Loading...
View Options

src/applications/harbormaster/storage/HarbormasterBuildTransaction.php

Loading...
View Options

src/applications/harbormaster/xaction/build/HarbormasterBuildMessageTransaction.php

Loading...
View Options

src/applications/harbormaster/xaction/build/HarbormasterBuildTransactionType.php

Loading...
Phabricator · Built by Phacility