Page MenuHomePhabricator
Differential D21689

Modularize HarbormasterBuildTransaction
ClosedPublic
Actions

Authored by epriestley on Jul 15 2021, 9:05 PM.
Tags
None
Referenced Files
F13190387: D21689.id51702.diff
Sat, May 11, 10:30 AM
F13187478: D21689.diff
Sat, May 11, 4:33 AM
F13182050: D21689.id.diff
Thu, May 9, 7:03 PM
Unknown Object (File)
Tue, May 7, 7:41 AM
Unknown Object (File)
Sun, May 5, 4:38 PM
Unknown Object (File)
Fri, May 3, 7:18 AM
Unknown Object (File)
Fri, Apr 26, 9:26 PM
Unknown Object (File)
Fri, Apr 26, 2:07 PM
View All Files
Subscribers
Restricted Owners Package

Details

Reviewers
None
Maniphest Tasks
T13072: Merge Harbormaster BuildCommand into BuildMessage
Commits
rP6dfea0adaddc: Modularize HarbormasterBuildTransaction
Summary

Ref T13072. Update "HarbormasterBuild" to use modern modular transactions.

Test Plan
  • Aborted, restarted, paused, and resumed a build.
  • Used bin/harbormaster restart.
  • Grepped for use of old "::TYPE_COMMAND" constant, didn't find any hits.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Jul 15 2021, 9:05 PM
Owners added a subscriber: Restricted Owners Package.Jul 15 2021, 9:05 PM
Harbormaster completed remote builds in B25454: Diff 51651.Jul 15 2021, 9:07 PM
epriestley requested review of this revision.Jul 15 2021, 9:07 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jul 21 2021, 9:17 PM
Closed by commit rP6dfea0adaddc: Modularize HarbormasterBuildTransaction (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP6dfea0adaddc: Modularize HarbormasterBuildTransaction.

Revision Contents
Changeset List

Diff 51702

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/harbormaster/editor/HarbormasterBuildTransactionEditor.php

Loading...
View Options

src/applications/harbormaster/engine/HarbormasterBuildEngine.php

Loading...
View Options

src/applications/harbormaster/management/HarbormasterManagementRestartWorkflow.php

Loading...
View Options

src/applications/harbormaster/storage/HarbormasterBuildTransaction.php

Loading...
View Options

src/applications/harbormaster/xaction/build/HarbormasterBuildMessageTransaction.php

Loading...
View Options

src/applications/harbormaster/xaction/build/HarbormasterBuildTransactionType.php

Loading...
Phabricator · Built by Phacility