Page MenuHomePhabricator

Merge the "HarbormasterBuildCommand" table into "HarbormasterBuildMessage"
ClosedPublic

Authored by epriestley on Jul 13 2021, 10:48 PM.
Tags
None
Referenced Files
F15430166: D21684.id.diff
Mon, Mar 24, 6:18 AM
F15430033: D21684.id51699.diff
Mon, Mar 24, 5:23 AM
F15429973: D21684.id51699.diff
Mon, Mar 24, 5:05 AM
F15429679: D21684.id.diff
Mon, Mar 24, 3:34 AM
F15428555: D21684.diff
Sun, Mar 23, 9:10 PM
F15427527: D21684.diff
Sun, Mar 23, 2:47 PM
F15422624: D21684.diff
Sat, Mar 22, 9:51 AM
F15419339: D21684.id51645.diff
Fri, Mar 21, 5:26 AM
Subscribers
Restricted Owners Package

Details

Summary

Ref T13072. These two similar tables don't make sense to keep separate. Instead, make Build a valid receiver for BuildMessage objects.

These tables are practically the same, so this is straightforward: just copy the rows in and then drop the old table.

(This table was trivial and ephemeral anyway, so I'm not bothering to do the usual "keep it around for a couple years just in case".)

Test Plan
  • Populated BuildCommand table, ran migration, saw Builds end up in the proper transitional state (e.g., pausing, aborting, restarting) with appropriate queued messages.
  • Queued new messages by clicking UI buttons.
  • Ran BuildWorkers, saw them process messages and mark them as consumed.

Diff Detail

Repository
rP Phabricator
Branch
build2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25448
Build 35164: Run Core Tests
Build 35163: arc lint + arc unit

Event Timeline

Owners added a subscriber: Restricted Owners Package.Jul 13 2021, 10:48 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jul 21 2021, 9:17 PM
This revision was automatically updated to reflect the committed changes.