Page MenuHomePhabricator

Merge the "HarbormasterBuildCommand" table into "HarbormasterBuildMessage"

Authored by epriestley on Jul 13 2021, 10:48 PM.
Referenced Files
F11631955: D21684.diff
Sat, Mar 25, 3:44 AM
Unknown Object (File)
Tue, Feb 28, 3:50 PM
Unknown Object (File)
Tue, Feb 28, 11:53 AM
Unknown Object (File)
Mon, Feb 27, 3:37 AM
Unknown Object (File)
Feb 19 2023, 8:04 PM
Unknown Object (File)
Feb 12 2023, 11:47 AM
Unknown Object (File)
Feb 9 2023, 6:38 PM
Unknown Object (File)
Feb 2 2023, 10:58 AM
Restricted Owners Package



Ref T13072. These two similar tables don't make sense to keep separate. Instead, make Build a valid receiver for BuildMessage objects.

These tables are practically the same, so this is straightforward: just copy the rows in and then drop the old table.

(This table was trivial and ephemeral anyway, so I'm not bothering to do the usual "keep it around for a couple years just in case".)

Test Plan
  • Populated BuildCommand table, ran migration, saw Builds end up in the proper transitional state (e.g., pausing, aborting, restarting) with appropriate queued messages.
  • Queued new messages by clicking UI buttons.
  • Ran BuildWorkers, saw them process messages and mark them as consumed.

Diff Detail

rP Phabricator
Lint Passed
Tests Passed
Build Status
Buildable 25448
Build 35164: Run Core Tests
Build 35163: arc lint + arc unit

Event Timeline

Owners added a subscriber: Restricted Owners Package.Jul 13 2021, 10:48 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jul 21 2021, 9:17 PM
This revision was automatically updated to reflect the committed changes.