Page MenuHomePhabricator

Merge the "HarbormasterBuildCommand" table into "HarbormasterBuildMessage"
ClosedPublic

Authored by epriestley on Jul 13 2021, 10:48 PM.
Tags
None
Referenced Files
F15392540: D21684.diff
Sat, Mar 15, 3:50 PM
F15389555: D21684.id.diff
Sat, Mar 15, 5:25 AM
F15379335: D21684.diff
Thu, Mar 13, 8:20 PM
F15360717: D21684.diff
Tue, Mar 11, 9:47 AM
F15333355: D21684.diff
Sat, Mar 8, 2:02 AM
F15304703: D21684.diff
Thu, Mar 6, 2:05 AM
Unknown Object (File)
Mon, Feb 24, 12:53 PM
Unknown Object (File)
Mon, Feb 24, 12:49 PM
Subscribers
Restricted Owners Package

Details

Summary

Ref T13072. These two similar tables don't make sense to keep separate. Instead, make Build a valid receiver for BuildMessage objects.

These tables are practically the same, so this is straightforward: just copy the rows in and then drop the old table.

(This table was trivial and ephemeral anyway, so I'm not bothering to do the usual "keep it around for a couple years just in case".)

Test Plan
  • Populated BuildCommand table, ran migration, saw Builds end up in the proper transitional state (e.g., pausing, aborting, restarting) with appropriate queued messages.
  • Queued new messages by clicking UI buttons.
  • Ran BuildWorkers, saw them process messages and mark them as consumed.

Diff Detail

Repository
rP Phabricator
Branch
build2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25448
Build 35164: Run Core Tests
Build 35163: arc lint + arc unit

Event Timeline

Owners added a subscriber: Restricted Owners Package.Jul 13 2021, 10:48 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jul 21 2021, 9:17 PM
This revision was automatically updated to reflect the committed changes.