Update a few random typos
ClosedPublic
Actions

Authored by cspeckmim on Jun 27 2021, 8:11 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rP96374208616b: Update a few random typos

Summary

Found a few typos which could be updated.

Test Plan

I tested the Configuration page change by navigating to /config and verifying the page title set in the browser as well as the page title text on the page

Before	After

I verified the Conduit error message by navigating to /auth/start/?__conduit__=1

The CircleCI error message was not verified due to the involvement of testing with CircleCI however the change is very minor and has very little risk of impacting any functionality.

Diff Detail

Repository

rP Phabricator

Branch

typos

Lint

Lint Passed

Unit

Tests Skipped

Build Status

Buildable 25391
Build 35058: Run Core Tests
Build 35057: arc lint + arc unit

Event Timeline

cspeckmim created this revision.Jun 27 2021, 8:11 PM

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 27 2021, 8:11 PM

Harbormaster completed remote builds in B25390: Diff 51585.Jun 27 2021, 8:12 PM

cspeckmim requested review of this revision.Jun 27 2021, 8:12 PM

Herald added a subscriber: Korvin. · View Herald TranscriptJun 27 2021, 8:12 PM

epriestley accepted this revision.Jun 27 2021, 8:37 PM

epriestley added inline comments.

src/applications/repository/storage/PhabricatorRepositoryCommit.php
716–718	Maybe "...which has a remote URI..." would be slightly clearer than "...with an X with a Y...".

This revision is now accepted and ready to land.Jun 27 2021, 8:37 PM

Oh, just for completeness -- you can trigger the first message by visiting this URI while logged out (e.g., in an incognito window):

http://your.install.com/auth/start/?__conduit__=1

Screen Shot 2021-06-27 at 1.39.08 PM.png (737×1 px, 112 KB)

The third message requires setting up a CircleCI build step in Harbormaster for an observed, non-GitHub repository. This is almost certainly not worth actually bothering to reproduce.

Update the phrasing

Also tested the conduit message:

Harbormaster completed remote builds in B25391: Diff 51586.Jun 27 2021, 8:44 PM

Re-balance the text line formatting with the new phrasing

Harbormaster completed remote builds in B25392: Diff 51587.Jun 27 2021, 8:46 PM

cspeckmim edited the test plan for this revision. (Show Details)Jun 27 2021, 8:49 PM

For landing the revision can that only be done through the "Land Revision" button? It's greyed out for me.

Oops -- I assumed you were already in Blessed Committers. I added you, you should be able to either arc land or "Land Revision" now (if arc diff uploaded to staging properly). See that project description for some details, or yell if you're still having issues.