Page MenuHomePhabricator

Update a few random typos
ClosedPublic

Authored by cspeckmim on Jun 27 2021, 8:11 PM.

Details

Summary

Found a few typos which could be updated.

Test Plan

I tested the Configuration page change by navigating to /config and verifying the page title set in the browser as well as the page title text on the page

BeforeAfter
Screen Shot 2021-06-27 at 3.59.55 PM.png (316×686 px, 29 KB)
Screen Shot 2021-06-27 at 4.01.39 PM.png (312×694 px, 29 KB)
Screen Shot 2021-06-27 at 4.47.18 PM.png (78×460 px, 14 KB)
Screen Shot 2021-06-27 at 4.46.55 PM.png (76×474 px, 14 KB)

I verified the Conduit error message by navigating to /auth/start/?__conduit__=1

Screen Shot 2021-06-27 at 4.42.31 PM.png (98×3 px, 42 KB)

The CircleCI error message was not verified due to the involvement of testing with CircleCI however the change is very minor and has very little risk of impacting any functionality.

Diff Detail

Repository
rP Phabricator
Branch
typos
Lint
Lint Passed
Unit
Tests Skipped
Build Status
Buildable 25391
Build 35058: Run Core Tests
Build 35057: arc lint + arc unit

Event Timeline

epriestley added inline comments.
src/applications/repository/storage/PhabricatorRepositoryCommit.php
716–718

Maybe "...which has a remote URI..." would be slightly clearer than "...with an X with a Y...".

This revision is now accepted and ready to land.Jun 27 2021, 8:37 PM

Oh, just for completeness -- you can trigger the first message by visiting this URI while logged out (e.g., in an incognito window):

http://your.install.com/auth/start/?__conduit__=1

Screen Shot 2021-06-27 at 1.39.08 PM.png (737×1 px, 112 KB)

The third message requires setting up a CircleCI build step in Harbormaster for an observed, non-GitHub repository. This is almost certainly not worth actually bothering to reproduce.

Update the phrasing

Also tested the conduit message:

Screen Shot 2021-06-27 at 4.42.31 PM.png (98×3 px, 42 KB)

Re-balance the text line formatting with the new phrasing

For landing the revision can that only be done through the "Land Revision" button? It's greyed out for me.

Oops -- I assumed you were already in Blessed Committers. I added you, you should be able to either arc land or "Land Revision" now (if arc diff uploaded to staging properly). See that project description for some details, or yell if you're still having issues.

This revision was automatically updated to reflect the committed changes.