Page MenuHomePhabricator

Fix an issue where inlines could be duplicated in the client list
ClosedPublic

Authored by epriestley on Mar 18 2021, 6:33 PM.
Tags
None
Referenced Files
F12839185: D21642.id51508.diff
Thu, Mar 28, 7:11 PM
Unknown Object (File)
Wed, Mar 27, 11:34 PM
Unknown Object (File)
Sun, Mar 24, 6:07 AM
Unknown Object (File)
Feb 21 2024, 6:27 AM
Unknown Object (File)
Feb 21 2024, 6:27 AM
Unknown Object (File)
Feb 21 2024, 6:27 AM
Unknown Object (File)
Feb 21 2024, 6:27 AM
Unknown Object (File)
Feb 7 2024, 8:13 PM
Subscribers
None

Details

Summary

Ref T13559. D21261 added caching here, but the logic in rebuilding inlines wasn't quite correct, and could lead to us double-appending.

Instead, when rebuilding, unconditionally discard the old list.

Test Plan
  • Added inline comments to a file in Differential.
  • Marked some done.
  • Scrolled so the inline comment header was visible, saw "X / Y Comments" button in header.
  • Clicked "Show 20 more lines" on the changeset with inlines (or toggle "View Unified" / "View Side-by-Side", or other interactions likely work too).
    • Before: saw "X / Y" change improperly (because inlines in that file were double-counted).
    • After: saw stable count.
  • Grepped for "differential-inline-comment-refresh", got no hits, concluded this event has no listeners.

Diff Detail

Repository
rP Phabricator
Branch
inline1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 25316
Build 34949: Run Core Tests
Build 34948: arc lint + arc unit