Page MenuHomePhabricator

Replace Differential "unit stars" with icons
ClosedPublic

Authored by epriestley on Mar 17 2021, 8:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 20, 5:42 PM
Unknown Object (File)
Sat, Apr 20, 8:04 AM
Unknown Object (File)
Wed, Apr 17, 3:44 PM
Unknown Object (File)
Mon, Apr 8, 2:14 AM
Unknown Object (File)
Mon, Apr 1, 8:41 PM
Unknown Object (File)
Wed, Mar 27, 10:36 PM
Unknown Object (File)
Feb 7 2024, 10:10 AM
Unknown Object (File)
Feb 4 2024, 12:54 AM
Subscribers
None

Details

Summary

Ref T9764. These "star" icons are unclear, inconsistent, and not friendly to colorblind users.

They date from a time long ago when the product didn't have icons.

Modernize them and make them more consistent with the similar statuses in Harbormaster.

Test Plan

Screen Shot 2021-03-17 at 1.24.47 PM.png (164×217 px, 6 KB)

Screen Shot 2021-03-17 at 1.24.18 PM.png (389×1 px, 37 KB)

Screen Shot 2021-03-17 at 1.24.40 PM.png (61×244 px, 4 KB)

Diff Detail

Repository
rP Phabricator
Branch
star1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25309
Build 34938: Run Core Tests
Build 34937: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Mar 17 2021, 8:46 PM
This revision was automatically updated to reflect the committed changes.