Page MenuHomePhabricator

Replace Differential "unit stars" with icons
ClosedPublic

Authored by epriestley on Mar 17 2021, 8:26 PM.
Tags
None
Referenced Files
F18593349: D21639.id.diff
Fri, Sep 12, 2:42 PM
F18584197: D21639.diff
Thu, Sep 11, 12:17 PM
F18571855: D21639.id51504.diff
Wed, Sep 10, 5:26 AM
F18571853: D21639.id51501.diff
Wed, Sep 10, 5:26 AM
F18365447: D21639.diff
Wed, Aug 27, 8:58 PM
F18201817: D21639.id51504.diff
Aug 18 2025, 8:49 AM
F18112380: D21639.diff
Aug 12 2025, 4:30 PM
F18110867: D21639.id51501.diff
Aug 12 2025, 1:00 AM
Subscribers
None

Details

Summary

Ref T9764. These "star" icons are unclear, inconsistent, and not friendly to colorblind users.

They date from a time long ago when the product didn't have icons.

Modernize them and make them more consistent with the similar statuses in Harbormaster.

Test Plan

Screen Shot 2021-03-17 at 1.24.47 PM.png (164×217 px, 6 KB)

Screen Shot 2021-03-17 at 1.24.18 PM.png (389×1 px, 37 KB)

Screen Shot 2021-03-17 at 1.24.40 PM.png (61×244 px, 4 KB)

Diff Detail

Repository
rP Phabricator
Branch
star1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25309
Build 34938: Run Core Tests
Build 34937: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Mar 17 2021, 8:46 PM
This revision was automatically updated to reflect the committed changes.