Differential D21620

Move Diffusion to "withPaths()" for "Recent Open Revisions", and remove "withPath()" from DifferentialRevisionQuery
ClosedPublic
Actions

Authored by epriestley on Mar 15 2021, 10:57 PM.

Details

Reviewers: None
Maniphest Tasks: T13639: Allow revisions to be queried by affected path via the API
Commits: rP6d33ba7dc401: Move Diffusion to "withPaths()" for "Recent Open Revisions", and remove…

Summary

Ref T13639. Move Diffusion to use the new API and get rid of the old API now that it no longer has any callers.

Test Plan

Grepped for remaining callers.

Diff Detail

Repository

rP Phabricator

Branch

recent9

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 25264
Build 34874: Run Core Tests
Build 34873: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 15 2021, 10:57 PM

Harbormaster completed remote builds in B25264: Diff 51456.Mar 15 2021, 10:58 PM

epriestley requested review of this revision.Mar 15 2021, 10:58 PM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 15 2021, 11:16 PM

Closed by commit rP6d33ba7dc401: Move Diffusion to "withPaths()" for "Recent Open Revisions", and remove… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP6d33ba7dc401: Move Diffusion to "withPaths()" for "Recent Open Revisions", and remove….

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

query/

DifferentialRevisionQuery.php

46 lines

diffusion/

controller/

DiffusionBrowseController.php

9 lines

Diff 51456

View Options

src/applications/differential/query/DifferentialRevisionQuery.php