Support a "withPaths()" API in DifferentialRevisionQuery, and use it on the revision view
ClosedPublic
Actions

Authored by epriestley on Mar 15 2021, 10:52 PM.

Tags

None

Referenced Files

	F15557829: D21619.id51455.diff
	Mon, Apr 28, 11:24 PM

	F15557038: D21619.id51465.diff
	Mon, Apr 28, 7:33 PM

	F15535753: D21619.id51465.diff
	Thu, Apr 24, 6:34 AM

	F15531287: D21619.id.diff
	Wed, Apr 23, 10:30 AM

	F15529804: D21619.diff
	Tue, Apr 22, 10:35 PM

	F15484662: D21619.id51465.diff
	Wed, Apr 9, 7:26 PM

	F15428838: D21619.id51455.diff
	Mar 23 2025, 10:44 PM

	F15415700: D21619.id51465.diff
	Mar 20 2025, 7:31 AM

View All Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13639: Allow revisions to be queried by affected path via the API
Commits: rP925c9a71e7ea: Support a "withPaths()" API in DifferentialRevisionQuery, and use it on the…

Summary

Ref T13639. Move away from "withPath(..., ...)" to "withPaths(...)".

Test Plan

Screen Shot 2021-03-15 at 3.50.41 PM.png (206×405 px, 15 KB)

Diff Detail

Repository

rP Phabricator

Branch

recent8

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 25263
Build 34872: Run Core Tests
Build 34871: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 15 2021, 10:52 PM

Harbormaster completed remote builds in B25263: Diff 51455.Mar 15 2021, 10:53 PM

epriestley requested review of this revision.Mar 15 2021, 10:53 PM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 15 2021, 11:16 PM

Closed by commit rP925c9a71e7ea: Support a "withPaths()" API in DifferentialRevisionQuery, and use it on the… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP925c9a71e7ea: Support a "withPaths()" API in DifferentialRevisionQuery, and use it on the….

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

controller/

DifferentialRevisionViewController.php

24 lines

query/

DifferentialRevisionQuery.php

67 lines

Diff 51455

View Options

src/applications/differential/controller/DifferentialRevisionViewController.php