Fix a followup notification paging error with partial objects
ClosedPublic
Actions

Authored by epriestley on Mar 12 2021, 5:08 PM.

Tags

None

Referenced Files

	F15413250: D21609.diff
	Wed, Mar 19, 5:38 PM

	F15410116: D21609.diff
	Wed, Mar 19, 6:47 AM

	F15291983: D21609.diff
	Wed, Mar 5, 1:30 AM

	Unknown Object (File)
	Sat, Mar 1, 12:26 PM

	Unknown Object (File)
	Wed, Feb 19, 11:42 PM

	Unknown Object (File)
	Wed, Feb 19, 7:37 PM

	Unknown Object (File)
	Tue, Feb 18, 8:58 AM

	Unknown Object (File)
	Feb 9 2025, 10:10 AM

View All Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13623: Notifications may fail to paginate with GROUP BY error
Commits: rP4b529e600928: Fix a followup notification paging error with partial objects

Summary

Ref T13623. In D21603, I made the "partial object" this query returns a raw row, which paging keys can no longer be extracted from properly.

Test Plan

Paged notifications to page 2, no longer saw an error.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Mar 12 2021, 5:08 PM

Harbormaster completed remote builds in B25248: Diff 51441.Mar 12 2021, 5:09 PM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 12 2021, 5:09 PM

epriestley requested review of this revision.

Closed by commit rP4b529e600928: Fix a followup notification paging error with partial objects (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP4b529e600928: Fix a followup notification paging error with partial objects.

Revision Contents
Changeset List

Path

Size

src/

applications/

notification/

query/

PhabricatorNotificationQuery.php

2 lines

Diff 51442

View Options

src/applications/notification/query/PhabricatorNotificationQuery.php

Fix a followup notification paging error with partial objectsClosedPublicActions