Page MenuHomePhabricator

Fix an error when users receive notifications about objects they can no longer see
ClosedPublic

Authored by epriestley on Mar 11 2021, 6:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
May 7 2025, 9:41 AM
Unknown Object (File)
Apr 27 2025, 9:36 AM
Unknown Object (File)
Apr 26 2025, 10:15 AM
Unknown Object (File)
Apr 26 2025, 7:20 AM
Unknown Object (File)
Apr 12 2025, 2:50 AM
Unknown Object (File)
Apr 9 2025, 6:24 AM
Unknown Object (File)
Apr 4 2025, 9:30 PM
Unknown Object (File)
Mar 28 2025, 11:11 PM
Subscribers
None

Details

Summary

Ref T13623. The change in D21577 could lead to a case where we try to access stories the user can't see.

Move the story-loading piece to "willFilterPage()" to make our way thorugh this.

Test Plan
  • Made FeedStory return nothing to simulate invisible notifications, loaded page.
    • Before: index access fatal.
    • After: clean "no notifications".
  • Loaded notifications normally, saw normal notifications.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable