Fix an error when users receive notifications about objects they can no longer see
ClosedPublic
Actions

Authored by epriestley on Mar 11 2021, 6:34 PM.

Details

Reviewers: None
Maniphest Tasks: T13623: Notifications may fail to paginate with GROUP BY error
Commits: rP0815891e4263: Fix an error when users receive notifications about objects they can no longer…

Summary

Ref T13623. The change in D21577 could lead to a case where we try to access stories the user can't see.

Move the story-loading piece to "willFilterPage()" to make our way thorugh this.

Test Plan

Made FeedStory return nothing to simulate invisible notifications, loaded page.
- Before: index access fatal.
- After: clean "no notifications".
Loaded notifications normally, saw normal notifications.

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

epriestley requested review of this revision.Mar 11 2021, 6:35 PM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 11 2021, 6:44 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

src/

applications/

notification/

query/

61 lines