Page MenuHomePhabricator

Fix a followup notification paging error with partial objects
ClosedPublic

Authored by epriestley on Mar 12 2021, 5:08 PM.
Tags
None
Referenced Files
F12808205: D21609.diff
Wed, Mar 27, 8:22 PM
Unknown Object (File)
Feb 14 2024, 11:09 PM
Unknown Object (File)
Jan 28 2024, 7:42 AM
Unknown Object (File)
Jan 21 2024, 4:47 PM
Unknown Object (File)
Jan 18 2024, 11:39 AM
Unknown Object (File)
Jan 16 2024, 3:09 AM
Unknown Object (File)
Jan 11 2024, 10:16 AM
Unknown Object (File)
Jan 7 2024, 5:29 PM
Subscribers
None

Details

Summary

Ref T13623. In D21603, I made the "partial object" this query returns a raw row, which paging keys can no longer be extracted from properly.

Test Plan

Paged notifications to page 2, no longer saw an error.

Diff Detail

Repository
rP Phabricator
Branch
notif3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25248
Build 34847: Run Core Tests
Build 34846: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Mar 12 2021, 5:09 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.