Fix a followup notification paging error with partial objects
ClosedPublic
Actions

Authored by epriestley on Mar 12 2021, 5:08 PM.

Details

Reviewers: None
Maniphest Tasks: T13623: Notifications may fail to paginate with GROUP BY error
Commits: rP4b529e600928: Fix a followup notification paging error with partial objects

Summary

Ref T13623. In D21603, I made the "partial object" this query returns a raw row, which paging keys can no longer be extracted from properly.

Test Plan

Paged notifications to page 2, no longer saw an error.

Repository

rP Phabricator

Branch

notif3

Lint

Lint Passed

Unit

Tests Passed

Build Status

This revision was not accepted when it landed; it landed in state Needs Review.Mar 12 2021, 5:09 PM

epriestley requested review of this revision.

This revision was automatically updated to reflect the committed changes.

Path

Size

src/

applications/

notification/

query/

2 lines