Page MenuHomePhabricator
Differential D21604

Improve "PhutilJSON" handling of PHP-object JSON values
ClosedPublic
Actions

Authored by epriestley on Mar 11 2021, 7:22 PM.
Tags
None
Referenced Files
F15409478: D21604.id51433.diff
Wed, Mar 19, 4:34 AM
F15387876: D21604.id51431.diff
Sat, Mar 15, 3:03 AM
F15378847: D21604.id51433.diff
Thu, Mar 13, 5:19 PM
F15310737: D21604.diff
Thu, Mar 6, 9:24 AM
Unknown Object (File)
Sun, Mar 2, 4:32 PM
Unknown Object (File)
Thu, Feb 27, 8:15 AM
Unknown Object (File)
Thu, Feb 27, 1:17 AM
Unknown Object (File)
Wed, Feb 26, 8:54 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13635: JSON DocumentEngine may confuse "{}" and "[]"
Commits
rARC7570dd0da119: Improve "PhutilJSON" handling of PHP-object JSON values
Summary

Ref T13635. PHP native JSON functions sometimes represent JSON objects as PHP "stdClass" objects.

Accept this representation and emit it correctly in "PhutilJSON".

Test Plan

Added a test, made it pass.

Diff Detail

Repository
rARC Arcanist
Branch
json1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25238
Build 34832: Run Core Tests
Build 34831: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 11 2021, 7:22 PM
Harbormaster completed remote builds in B25238: Diff 51431.Mar 11 2021, 7:22 PM
epriestley requested review of this revision.Mar 11 2021, 7:22 PM
This revision was not accepted when it landed; it landed in state Needs Review.Mar 11 2021, 8:43 PM
Closed by commit rARC7570dd0da119: Improve "PhutilJSON" handling of PHP-object JSON values (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rARC7570dd0da119: Improve "PhutilJSON" handling of PHP-object JSON values.

Revision Contents
Changeset List

PathSize
src/
parser/
8 lines
__tests__/
29 lines

Diff 51431

View Options

src/parser/PhutilJSON.php

Loading...
View Options

src/parser/__tests__/PhutilJSONTestCase.php

Loading...
Phabricator · Built by Phacility