Differential D21604

Improve "PhutilJSON" handling of PHP-object JSON values
ClosedPublic
Actions

Authored by epriestley on Mar 11 2021, 7:22 PM.

Details

Reviewers: None
Maniphest Tasks: T13635: JSON DocumentEngine may confuse "{}" and "[]"
Commits: rARC7570dd0da119: Improve "PhutilJSON" handling of PHP-object JSON values

Summary

Ref T13635. PHP native JSON functions sometimes represent JSON objects as PHP "stdClass" objects.

Accept this representation and emit it correctly in "PhutilJSON".

Test Plan

Added a test, made it pass.

Diff Detail

Repository

rARC Arcanist

Branch

json1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 25238
Build 34832: Run Core Tests
Build 34831: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 11 2021, 7:22 PM

Harbormaster completed remote builds in B25238: Diff 51431.Mar 11 2021, 7:22 PM

epriestley requested review of this revision.Mar 11 2021, 7:22 PM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 11 2021, 8:43 PM

Closed by commit rARC7570dd0da119: Improve "PhutilJSON" handling of PHP-object JSON values (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARC7570dd0da119: Improve "PhutilJSON" handling of PHP-object JSON values.

Revision Contents
Changeset List

Path

Size

src/

parser/

PhutilJSON.php

8 lines

__tests__/

PhutilJSONTestCase.php

29 lines

Diff 51431

View Options

src/parser/PhutilJSON.php

View Options

src/parser/tests/PhutilJSONTestCase.php

Improve "PhutilJSON" handling of PHP-object JSON valuesClosedPublicActions