Page MenuHomePhabricator

Improve rendering behavior for "foist upon" with an empty tokenizer
ClosedPublic

Authored by epriestley on Mar 4 2021, 12:01 AM.
Tags
None
Referenced Files
F19003354: D21592.id.diff
Nov 21 2025, 8:24 AM
F18852858: D21592.id51408.diff
Oct 31 2025, 12:34 PM
F18808764: D21592.id.diff
Oct 19 2025, 8:25 AM
F18803469: D21592.diff
Oct 18 2025, 12:20 AM
F18783572: D21592.id51407.diff
Oct 13 2025, 8:13 AM
F18783298: D21592.id51407.diff
Oct 13 2025, 5:51 AM
F18783249: D21592.id51407.diff
Oct 13 2025, 5:24 AM
F18759126: D21592.id.diff
Oct 6 2025, 1:58 AM
Subscribers
None

Details

Summary

Ref T13628. If you "Foist Upon", then delete the value in the tokenizer, then scroll down to the preview, you currently get an ugly "Unknown Object (???)" rendering.

This is technically correct in some vague sense and the transaction won't apply, but provide a more aesthetic rendering instead.

Test Plan

Screen Shot 2021-03-03 at 3.58.38 PM.png (531×589 px, 31 KB)

Diff Detail

Repository
rP Phabricator
Branch
foist2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25212
Build 34794: Run Core Tests
Build 34793: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Mar 4 2021, 12:08 AM
This revision was automatically updated to reflect the committed changes.