Improve rendering behavior for "foist upon" with an empty tokenizer
ClosedPublic
Actions

Authored by epriestley on Mar 4 2021, 12:01 AM.

Details

Reviewers: None
Maniphest Tasks: T13628: Provide "Foist Upon", an inverse operation to "Commandeer"
Commits: rPf3caf7e9fcd6: Improve rendering behavior for "foist upon" with an empty tokenizer

Summary

Ref T13628. If you "Foist Upon", then delete the value in the tokenizer, then scroll down to the preview, you currently get an ugly "Unknown Object (???)" rendering.

This is technically correct in some vague sense and the transaction won't apply, but provide a more aesthetic rendering instead.

Test Plan

Screen Shot 2021-03-03 at 3.58.38 PM.png (531×589 px, 31 KB)

Diff Detail

Repository

rP Phabricator

Branch

foist2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 25212
Build 34794: Run Core Tests
Build 34793: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 4 2021, 12:01 AM

Harbormaster completed remote builds in B25212: Diff 51407.Mar 4 2021, 12:02 AM

epriestley requested review of this revision.Mar 4 2021, 12:02 AM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 4 2021, 12:08 AM

Closed by commit rPf3caf7e9fcd6: Improve rendering behavior for "foist upon" with an empty tokenizer (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPf3caf7e9fcd6: Improve rendering behavior for "foist upon" with an empty tokenizer.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

xaction/

DifferentialRevisionAuthorTransaction.php

18 lines

Diff 51407

View Options

src/applications/differential/xaction/DifferentialRevisionAuthorTransaction.php

Improve rendering behavior for "foist upon" with an empty tokenizerClosedPublicActions