Page MenuHomePhabricator
Differential D21568

Add a negative lookbehind to the Remarkup "bare URI" regular expression pattern
ClosedPublic
Actions

Authored by epriestley on Feb 18 2021, 7:56 PM.
Tags
None
Referenced Files
F15534298: D21568.id51339.diff
Wed, Apr 23, 11:40 PM
F15521268: D21568.id51340.diff
Sun, Apr 20, 12:40 PM
F15521267: D21568.id.diff
Sun, Apr 20, 12:40 PM
F15453551: D21568.id51340.diff
Mar 29 2025, 12:37 PM
F15451222: D21568.id.diff
Mar 28 2025, 8:50 PM
F15444429: D21568.diff
Mar 27 2025, 9:35 AM
F15434157: D21568.id51339.diff
Mar 25 2025, 2:18 AM
F15425009: D21568.diff
Mar 23 2025, 1:48 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13608: Remarkup hyperlink pattern may backtrack explosively
Commits
rP8cfd22c5fe88: Add a negative lookbehind to the Remarkup "bare URI" regular expression pattern
Summary

Ref T13608. Building on D21562, further anchor this pattern by adding a negative lookbehind.

Test Plan

Ran unit tests.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 18 2021, 7:56 PM
Harbormaster completed remote builds in B25148: Diff 51339.Feb 18 2021, 7:58 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 18 2021, 7:58 PM
epriestley requested review of this revision.
Closed by commit rP8cfd22c5fe88: Add a negative lookbehind to the Remarkup "bare URI" regular expression pattern (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP8cfd22c5fe88: Add a negative lookbehind to the Remarkup "bare URI" regular expression pattern.

Revision Contents
Changeset List

PathSize
src/
infrastructure/
markup/
markuprule/
13 lines

Diff 51340

View Options

src/infrastructure/markup/markuprule/PhutilRemarkupHyperlinkRule.php

Loading...
Phabricator · Built by Phacility