Page MenuHomePhabricator
Differential D21568

Add a negative lookbehind to the Remarkup "bare URI" regular expression pattern
ClosedPublic
Actions

Authored by epriestley on Feb 18 2021, 7:56 PM.
Tags
None
Referenced Files
F19029673: D21568.diff
Mon, Nov 24, 6:43 PM
F18993614: D21568.id51339.diff
Wed, Nov 19, 8:12 AM
F18806214: D21568.id.diff
Oct 18 2025, 6:29 PM
F18798750: D21568.diff
Oct 17 2025, 8:22 AM
F18785805: D21568.id51340.diff
Oct 14 2025, 11:57 AM
F18773530: D21568.id51339.diff
Oct 9 2025, 10:33 AM
F18770451: D21568.id51340.diff
Oct 8 2025, 12:37 PM
F18734402: D21568.id.diff
Sep 30 2025, 10:53 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13608: Remarkup hyperlink pattern may backtrack explosively
Commits
rP8cfd22c5fe88: Add a negative lookbehind to the Remarkup "bare URI" regular expression pattern
Summary

Ref T13608. Building on D21562, further anchor this pattern by adding a negative lookbehind.

Test Plan

Ran unit tests.

Diff Detail

Repository
rP Phabricator
Branch
regex1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25148
Build 34709: Run Core Tests
Build 34708: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 18 2021, 7:56 PM
Harbormaster completed remote builds in B25148: Diff 51339.Feb 18 2021, 7:58 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 18 2021, 7:58 PM
epriestley requested review of this revision.
Closed by commit rP8cfd22c5fe88: Add a negative lookbehind to the Remarkup "bare URI" regular expression pattern (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP8cfd22c5fe88: Add a negative lookbehind to the Remarkup "bare URI" regular expression pattern.

Revision Contents
Changeset List

PathSize
src/
infrastructure/
markup/
markuprule/
13 lines

Diff 51339

View Options

src/infrastructure/markup/markuprule/PhutilRemarkupHyperlinkRule.php

Loading...
Phabricator · Built by Phacility