Page MenuHomePhabricator

Remove "final" from "private" methods in Phabricator
ClosedPublic

Authored by epriestley on Feb 3 2021, 10:11 PM.
Tags
None
Referenced Files
F15410958: D21540.diff
Wed, Mar 19, 8:44 AM
F15389181: D21540.id51272.diff
Sat, Mar 15, 4:58 AM
F15387835: D21540.id51273.diff
Sat, Mar 15, 2:59 AM
F15379272: D21540.id.diff
Thu, Mar 13, 7:55 PM
F15345261: D21540.id51273.diff
Mon, Mar 10, 9:34 AM
F15303980: D21540.id51273.diff
Thu, Mar 6, 1:16 AM
F15293855: D21540.id51272.diff
Wed, Mar 5, 5:11 AM
F15292415: D21540.id.diff
Wed, Mar 5, 2:14 AM
Subscribers
None

Details

Summary

Ref T13588. This has never been meaningful, but a "final private" method is specifically forbidden in PHP8.

Remove meaningless "final" from these methods, per new lint checks.

Test Plan

Ran arc lint --everything to identify affected methods, then ... | xargs -n1 arc lint --apply-patches.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Feb 3 2021, 10:13 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.