Page MenuHomePhabricator

Remove "final" from "private" methods in Phabricator
ClosedPublic

Authored by epriestley on Feb 3 2021, 10:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 27, 12:43 PM
Unknown Object (File)
Sat, Mar 16, 12:19 PM
Unknown Object (File)
Sun, Mar 10, 7:33 AM
Unknown Object (File)
Feb 26 2024, 10:00 AM
Unknown Object (File)
Feb 26 2024, 10:00 AM
Unknown Object (File)
Feb 17 2024, 7:04 AM
Unknown Object (File)
Feb 17 2024, 6:48 AM
Unknown Object (File)
Feb 16 2024, 12:23 PM
Subscribers
None

Details

Summary

Ref T13588. This has never been meaningful, but a "final private" method is specifically forbidden in PHP8.

Remove meaningless "final" from these methods, per new lint checks.

Test Plan

Ran arc lint --everything to identify affected methods, then ... | xargs -n1 arc lint --apply-patches.

Diff Detail

Repository
rP Phabricator
Branch
final1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25086
Build 34616: Run Core Tests
Build 34615: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Feb 3 2021, 10:13 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.