Page MenuHomePhabricator

Remove "final" from "private" methods in Phabricator
ClosedPublic

Authored by epriestley on Feb 3 2021, 10:11 PM.
Tags
None
Referenced Files
F18974618: D21540.id51272.diff
Sat, Nov 15, 10:36 PM
F18965613: D21540.id.diff
Fri, Nov 14, 5:22 PM
F18951365: D21540.diff
Wed, Nov 12, 3:55 AM
F18752130: D21540.id51272.diff
Oct 4 2025, 2:13 PM
F18645740: D21540.id51273.diff
Sep 19 2025, 8:28 AM
F18635525: D21540.id.diff
Sep 17 2025, 1:44 AM
F18577486: D21540.id.diff
Sep 10 2025, 7:07 PM
F18571543: D21540.id51273.diff
Sep 10 2025, 5:07 AM
Subscribers
None

Details

Summary

Ref T13588. This has never been meaningful, but a "final private" method is specifically forbidden in PHP8.

Remove meaningless "final" from these methods, per new lint checks.

Test Plan

Ran arc lint --everything to identify affected methods, then ... | xargs -n1 arc lint --apply-patches.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Feb 3 2021, 10:13 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.