Ref T13588. This has never been meaningful, but a "final private" method is specifically forbidden in PHP8.
Remove meaningless "final" from these methods, per new lint checks.
Details
Details
- Reviewers
- None
- Maniphest Tasks
- T13588: PHP 8 Compatibility
- Commits
- rP9502312b60ae: Remove "final" from "private" methods in Phabricator
Ran arc lint --everything to identify affected methods, then ... | xargs -n1 arc lint --apply-patches.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- final1
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 25086 Build 34616: Run Core Tests Build 34615: arc lint + arc unit