Page MenuHomePhabricator
Differential D21539

Detect and correct "final private" methods in lint
ClosedPublic
Actions

Authored by epriestley on Feb 3 2021, 9:53 PM.
Tags
None
Referenced Files
F13126397: D21539.id.diff
Tue, Apr 30, 4:09 PM
Unknown Object (File)
Mon, Apr 29, 4:28 PM
Unknown Object (File)
Sat, Apr 27, 12:27 PM
Unknown Object (File)
Fri, Apr 26, 2:57 PM
Unknown Object (File)
Thu, Apr 25, 12:07 AM
Unknown Object (File)
Sun, Apr 21, 11:39 AM
Unknown Object (File)
Sat, Apr 20, 5:32 PM
Unknown Object (File)
Thu, Apr 11, 8:24 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13588: PHP 8 Compatibility
Commits
rARCc51a996fb0bb: Detect and correct "final private" methods in lint
Summary

Ref T13588. Marking a method "final private" has never been meaningful, and is an error in PHP8.

Add static analysis to detect (and correct) this issue.

Test Plan

Added unit tests, will lint "phabricator/".

Diff Detail

Repository
rARC Arcanist
Branch
lint3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25085
Build 34614: Run Core Tests
Build 34613: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 3 2021, 9:53 PM
Harbormaster completed remote builds in B25085: Diff 51271.Feb 3 2021, 9:53 PM
epriestley requested review of this revision.Feb 3 2021, 9:53 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 3 2021, 10:14 PM
Closed by commit rARCc51a996fb0bb: Detect and correct "final private" methods in lint (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rARCc51a996fb0bb: Detect and correct "final private" methods in lint.
epriestley mentioned this in T13588: PHP 8 Compatibility.Feb 3 2021, 10:52 PM

Revision Contents
Changeset List

PathSize
src/
lint/
linter/
xhpast/
rules/
78 lines
__tests__/
invalid-modifiers/
26 lines
parser/
aast/
api/
11 lines

Diff 51271

View Options

src/lint/linter/xhpast/rules/ArcanistInvalidModifiersXHPASTLinterRule.php

Loading...
View Options

src/lint/linter/xhpast/rules/__tests__/invalid-modifiers/invalid-modifiers.lint-test

Loading...
View Options

src/parser/aast/api/AASTToken.php

Loading...
Phabricator · Built by Phacility