Differential D21509

Provide "gitsprintf(...)" and disambiguate Git ref selectors
ClosedPublic
Actions

Authored by epriestley on Jan 12 2021, 8:09 PM.

Details

Reviewers: None
Maniphest Tasks: T13589: Git may interpret refnames as flags in some commands which accept both refs and paths
Commits: rARCb2e715fc5a9c: Provide "gitsprintf(...)" and disambiguate Git ref selectors

Summary

Ref T13589. See that task for discussion.

Test Plan

Created this diff, ran most commands in isolation.
This change is difficult to test extensively.

Diff Detail

Repository

rARC Arcanist

Branch

git1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 25008
Build 34502: Run Core Tests
Build 34501: arc lint + arc unit

Event Timeline

epriestley created this revision.Jan 12 2021, 8:09 PM

Harbormaster completed remote builds in B25008: Diff 51195.Jan 12 2021, 8:10 PM

epriestley requested review of this revision.Jan 12 2021, 8:10 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jan 13 2021, 8:31 PM

Closed by commit rARCb2e715fc5a9c: Provide "gitsprintf(...)" and disambiguate Git ref selectors (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARCb2e715fc5a9c: Provide "gitsprintf(...)" and disambiguate Git ref selectors.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

land/

engine/

ArcanistGitLandEngine.php

28 lines

query/

ArcanistGitCommitMessageHardpointQuery.php

2 lines

repository/

api/

ArcanistGitAPI.php

48 lines

graph/

query/

ArcanistGitCommitGraphQuery.php

2 lines

xsprintf/

__tests__/

PhutilGitsprintfTestCase.php

40 lines

gitsprintf.php

64 lines

Diff 51195

View Options

src/__phutil_library_map__.php

View Options

src/land/engine/ArcanistGitLandEngine.php

View Options

src/query/ArcanistGitCommitMessageHardpointQuery.php

View Options

src/repository/api/ArcanistGitAPI.php

View Options

src/repository/graph/query/ArcanistGitCommitGraphQuery.php

View Options

src/xsprintf/tests/PhutilGitsprintfTestCase.php

View Options

src/xsprintf/gitsprintf.php

Provide "gitsprintf(...)" and disambiguate Git ref selectorsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 51195

src/__phutil_library_map__.php

src/land/engine/ArcanistGitLandEngine.php

src/query/ArcanistGitCommitMessageHardpointQuery.php

src/repository/api/ArcanistGitAPI.php

src/repository/graph/query/ArcanistGitCommitGraphQuery.php

src/xsprintf/__tests__/PhutilGitsprintfTestCase.php

src/xsprintf/gitsprintf.php

Provide "gitsprintf(...)" and disambiguate Git ref selectors
ClosedPublic
Actions

Revision Contents
Changeset List

src/xsprintf/tests/PhutilGitsprintfTestCase.php