HomePhabricator

Fix pyflakes tests for recent pyflakes versions

Description

Fix pyflakes tests for recent pyflakes versions

Summary:
Since 2.1.0 (commit 75bc0c03c145), pyflakes has included the Python
version and platform in its version output, so ignore it if present.

Since 2.2.0 (commit 6ba3f8e0b59b), pyflakes has included the column
number in its messages, so update the parser to include it and drop the
column number from the (only) test in order to work with both old and
new versions. Whilst here, assign names to the capture groups to make
the code clearer.

Test Plan: Ran arc unit

Reviewers: epriestley, joshuaspence, Blessed Reviewers

Reviewed By: epriestley, Blessed Reviewers

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D21504

Details

Provenance
jrtc27Authored on Mon, Jan 11, 4:52 AM
industryPushed on Mon, Jan 11, 4:52 AM
Reviewer
Blessed Reviewers
Differential Revision
D21504: Fix pyflakes tests for recent pyflakes versions
Parents
rARC09cff8611ba4: Fix ArcanistJSHintLinterTestCase::testLinter for recent JSHint
Branches
Unknown
Tags
Unknown
Build Status
Buildable 25001
Build 34491: Run Core Tests