Paths

Table of Contentst

Differential D21472

When printing, wrap all content in Remarkup tables more aggressively
ClosedPublic
Actions

Authored by epriestley on Sep 28 2020, 4:22 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Jan 26, 11:31 PM

	Unknown Object (File)
	Sat, Jan 25, 8:44 AM

	Unknown Object (File)
	Sat, Jan 25, 8:44 AM

	Unknown Object (File)
	Sat, Jan 25, 8:44 AM

	Unknown Object (File)
	Tue, Jan 21, 11:07 AM

	Unknown Object (File)
	Fri, Jan 17, 10:41 AM

	Unknown Object (File)
	Sun, Jan 12, 7:25 AM

	Unknown Object (File)
	Sun, Jan 5, 3:37 PM

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13564: Remarkup tables should show all content when printed to PDF
Commits: rPa5f20f710669: When printing, wrap all content in Remarkup tables more aggressively

Summary

Ref T13564. See PHI1798. Earlier efforts here (see D21439) still leave us with:

Incorrect behavior for long URIs, like http://www.example.com/MMMMM....
Incorrect beahvior for long text blocks, like MMMMMM....
Undesirable behavior for monospaced text in non-printing contexts (it wraps when we'd prefer it not wrap).

Apply the wrapping rules to all "<td>" content to resolve these three prongs.

Test Plan

Viewed long URIs, text blocks, and monospaced text in and out of tables, while printed and not printed, in Safari, Firefox, and Chrome.
All browser behavior now appears to be correct ("all content is preserved in printed document").
Some browser behavior when making wrapping choices is questionable, but I can't find an automatic solution for that.

Diff Detail

Repository

Branch

wrap1

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 24923
Build 34384: Run Core Tests
Build 34383: arc lint + arc unit

Event Timeline

epriestley created this revision.Sep 28 2020, 4:22 PM

Harbormaster completed remote builds in B24923: Diff 51107.Sep 28 2020, 4:23 PM

epriestley requested review of this revision.Sep 28 2020, 4:23 PM

Here's the remaining goofy behavior:

Screen Shot 2020-09-28 at 8.59.24 AM.png (447×762 px, 43 KB)

This revision was not accepted when it landed; it landed in state Needs Review.Sep 28 2020, 4:47 PM

Closed by commit rPa5f20f710669: When printing, wrap all content in Remarkup tables more aggressively (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPa5f20f710669: When printing, wrap all content in Remarkup tables more aggressively.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

webroot/

rsrc/

css/

core/

17 lines

Diff 51107

resources/celerity/map.php

Loading...

webroot/rsrc/css/core/remarkup.css

Loading...