Paths

Table of Contentst

Differential D21467

In ConduitCallFuture, only call Conduit exception messages on Conduit exceptions
ClosedPublic
Actions

Authored by epriestley on Sep 17 2020, 8:19 PM.

Tags

None

Referenced Files

	F15406691: D21467.diff
	Tue, Mar 18, 1:22 PM

	F15379533: D21467.diff
	Thu, Mar 13, 9:42 PM

	F15302815: D21467.id51097.diff
	Wed, Mar 5, 10:20 PM

	F15297103: D21467.id.diff
	Wed, Mar 5, 11:57 AM

	F15285618: D21467.id51096.diff
	Tue, Mar 4, 2:49 PM

	Unknown Object (File)
	Mon, Mar 3, 3:43 PM

	Unknown Object (File)
	Fri, Feb 21, 2:57 PM

	Unknown Object (File)
	Wed, Feb 19, 9:22 PM

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13582: Exception handling in ConduitFuture for raw HTTP exceptions lacks tailoring
Commits: rARC563dc2a993ec: In ConduitCallFuture, only call Conduit exception messages on Conduit exceptions

Summary

Ref T13582. When this code is reached with a raw HTTP exception, it currently fatals.

Test Plan

Ran arc branches --conduit-uri=http://example.org (a bad Conduit URI).
Before: hard fatal with a bad method call.
After: non-Conduit exception raised to user. Not ideal, but a step forward.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Sep 17 2020, 8:19 PM

Harbormaster completed remote builds in B24911: Diff 51096.Sep 17 2020, 8:19 PM

This revision was not accepted when it landed; it landed in state Needs Review.Sep 17 2020, 8:19 PM

epriestley requested review of this revision.

Closed by commit rARC563dc2a993ec: In ConduitCallFuture, only call Conduit exception messages on Conduit exceptions (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in rARC563dc2a993ec: In ConduitCallFuture, only call Conduit exception messages on Conduit exceptions.

epriestley added a commit: rARC563dc2a993ec: In ConduitCallFuture, only call Conduit exception messages on Conduit exceptions.

Revision Contents
Changeset List

Path

Size

src/

conduit/

ArcanistConduitCallFuture.php

21 lines

Diff 51097

src/conduit/ArcanistConduitCallFuture.php

Loading...