Page MenuHomePhabricator

In ConduitCallFuture, only call Conduit exception messages on Conduit exceptions
ClosedPublic

Authored by epriestley on Sep 17 2020, 8:19 PM.
Tags
None
Referenced Files
F19823912: D21467.id51097.diff
Sat, Mar 7, 4:45 PM
F19822510: D21467.id51097.diff
Sat, Mar 7, 6:06 AM
F19821143: D21467.diff
Fri, Mar 6, 7:06 PM
F19620028: D21467.id51097.diff
Feb 4 2026, 11:38 AM
F19616836: D21467.id51096.diff
Feb 4 2026, 3:27 AM
F19582496: D21467.id51096.diff
Feb 1 2026, 10:30 PM
F19534176: D21467.diff
Jan 20 2026, 10:43 PM
F19469934: D21467.id51096.diff
Jan 5 2026, 6:39 AM
Subscribers
None

Details

Summary

Ref T13582. When this code is reached with a raw HTTP exception, it currently fatals.

Test Plan
  • Ran arc branches --conduit-uri=http://example.org (a bad Conduit URI).
  • Before: hard fatal with a bad method call.
  • After: non-Conduit exception raised to user. Not ideal, but a step forward.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable