Page MenuHomePhabricator

In ConduitCallFuture, only call Conduit exception messages on Conduit exceptions
ClosedPublic

Authored by epriestley on Sep 17 2020, 8:19 PM.
Tags
None
Referenced Files
F15453443: D21467.id51097.diff
Sat, Mar 29, 11:49 AM
F15450285: D21467.id51096.diff
Fri, Mar 28, 2:52 PM
F15443481: D21467.id.diff
Thu, Mar 27, 4:38 AM
F15439255: D21467.diff
Wed, Mar 26, 6:35 AM
F15434373: D21467.id.diff
Tue, Mar 25, 3:16 AM
F15426305: D21467.diff
Sun, Mar 23, 7:58 AM
F15406691: D21467.diff
Tue, Mar 18, 1:22 PM
F15379533: D21467.diff
Thu, Mar 13, 9:42 PM
Subscribers
None

Details

Summary

Ref T13582. When this code is reached with a raw HTTP exception, it currently fatals.

Test Plan
  • Ran arc branches --conduit-uri=http://example.org (a bad Conduit URI).
  • Before: hard fatal with a bad method call.
  • After: non-Conduit exception raised to user. Not ideal, but a step forward.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable