Paths

Table of Contentst

Differential D21467

In ConduitCallFuture, only call Conduit exception messages on Conduit exceptions
ClosedPublic
Actions

Authored by epriestley on Sep 17 2020, 8:19 PM.

Tags

None

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13582: Exception handling in ConduitFuture for raw HTTP exceptions lacks tailoring
Commits: rARC563dc2a993ec: In ConduitCallFuture, only call Conduit exception messages on Conduit exceptions

Summary

Ref T13582. When this code is reached with a raw HTTP exception, it currently fatals.

Test Plan

Ran arc branches --conduit-uri=http://example.org (a bad Conduit URI).
Before: hard fatal with a bad method call.
After: non-Conduit exception raised to user. Not ideal, but a step forward.

Diff Detail

Repository

Branch

ex1

Lint

Lint OK

Unit

Unit Tests OK

Build Status

Buildable 24911
Build 34368: Run Core Tests
Build 34367: arc lint + arc unit

Event Timeline

epriestley created this revision.Sep 17 2020, 8:19 PM

Harbormaster completed remote builds in B24911: Diff 51096.Sep 17 2020, 8:19 PM

This revision was not accepted when it landed; it landed in state Needs Review.Sep 17 2020, 8:19 PM

epriestley requested review of this revision.

Closed by commit rARC563dc2a993ec: In ConduitCallFuture, only call Conduit exception messages on Conduit exceptions (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in rARC563dc2a993ec: In ConduitCallFuture, only call Conduit exception messages on Conduit exceptions.

epriestley added a commit: rARC563dc2a993ec: In ConduitCallFuture, only call Conduit exception messages on Conduit exceptions.

Revision Contents
Changeset List

Path

Size

src/

conduit/

ArcanistConduitCallFuture.php

21 lines

Diff 51096

src/conduit/ArcanistConduitCallFuture.php

Loading...