Page MenuHomePhabricator

In ConduitCallFuture, only call Conduit exception messages on Conduit exceptions
ClosedPublic

Authored by epriestley on Sep 17 2020, 8:19 PM.
Tags
None
Referenced Files
F18788930: D21467.diff
Wed, Oct 15, 7:08 AM
F18685021: D21467.id51097.diff
Fri, Sep 26, 10:30 AM
F18682280: D21467.diff
Fri, Sep 26, 5:37 AM
F18616033: D21467.diff
Sep 14 2025, 3:58 PM
F18615999: D21467.diff
Sep 14 2025, 3:48 PM
F18615965: D21467.diff
Sep 14 2025, 3:26 PM
F18615839: D21467.diff
Sep 14 2025, 3:16 PM
F18615602: D21467.diff
Sep 14 2025, 3:04 PM
Subscribers
None

Details

Summary

Ref T13582. When this code is reached with a raw HTTP exception, it currently fatals.

Test Plan
  • Ran arc branches --conduit-uri=http://example.org (a bad Conduit URI).
  • Before: hard fatal with a bad method call.
  • After: non-Conduit exception raised to user. Not ideal, but a step forward.

Diff Detail

Repository
rARC Arcanist
Branch
ex1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24911
Build 34368: Run Core Tests
Build 34367: arc lint + arc unit