Page MenuHomePhabricator

In ConduitCallFuture, only call Conduit exception messages on Conduit exceptions
ClosedPublic

Authored by epriestley on Sep 17 2020, 8:19 PM.
Tags
None
Referenced Files
F14091598: D21467.diff
Mon, Nov 25, 1:03 AM
Unknown Object (File)
Sat, Nov 23, 2:11 PM
Unknown Object (File)
Fri, Nov 22, 7:17 AM
Unknown Object (File)
Thu, Nov 21, 1:45 PM
Unknown Object (File)
Wed, Nov 20, 7:05 AM
Unknown Object (File)
Sun, Nov 17, 3:04 PM
Unknown Object (File)
Thu, Nov 14, 6:51 AM
Unknown Object (File)
Fri, Nov 8, 11:09 AM
Subscribers
None

Details

Summary

Ref T13582. When this code is reached with a raw HTTP exception, it currently fatals.

Test Plan
  • Ran arc branches --conduit-uri=http://example.org (a bad Conduit URI).
  • Before: hard fatal with a bad method call.
  • After: non-Conduit exception raised to user. Not ideal, but a step forward.

Diff Detail

Repository
rARC Arcanist
Branch
ex1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24911
Build 34368: Run Core Tests
Build 34367: arc lint + arc unit