Page MenuHomePhabricator

In ConduitCallFuture, only call Conduit exception messages on Conduit exceptions
ClosedPublic

Authored by epriestley on Sep 17 2020, 8:19 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jul 1, 2:32 AM
Unknown Object (File)
Tue, Jun 23, 9:46 AM
Unknown Object (File)
Tue, Jun 23, 9:46 AM
Unknown Object (File)
Tue, Jun 23, 9:46 AM
Unknown Object (File)
Apr 12 2026, 2:43 AM
Unknown Object (File)
Mar 29 2026, 10:41 AM
Unknown Object (File)
Mar 7 2026, 4:45 PM
Unknown Object (File)
Mar 7 2026, 6:06 AM
Subscribers
None

Details

Summary

Ref T13582. When this code is reached with a raw HTTP exception, it currently fatals.

Test Plan
  • Ran arc branches --conduit-uri=http://example.org (a bad Conduit URI).
  • Before: hard fatal with a bad method call.
  • After: non-Conduit exception raised to user. Not ideal, but a step forward.

Diff Detail

Repository
rARC Arcanist
Branch
ex1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24911
Build 34368: Run Core Tests
Build 34367: arc lint + arc unit