Page MenuHomePhabricator

In ConduitCallFuture, only call Conduit exception messages on Conduit exceptions
ClosedPublic

Authored by epriestley on Sep 17 2020, 8:19 PM.
Tags
None
Referenced Files
Unknown Object (File)
Jun 7 2025, 7:21 PM
Unknown Object (File)
Jun 5 2025, 5:04 PM
Unknown Object (File)
Apr 28 2025, 1:00 PM
Unknown Object (File)
Apr 27 2025, 3:33 AM
Unknown Object (File)
Apr 26 2025, 6:18 AM
Unknown Object (File)
Apr 17 2025, 7:58 AM
Unknown Object (File)
Mar 29 2025, 11:49 AM
Unknown Object (File)
Mar 28 2025, 2:52 PM
Subscribers
None

Details

Summary

Ref T13582. When this code is reached with a raw HTTP exception, it currently fatals.

Test Plan
  • Ran arc branches --conduit-uri=http://example.org (a bad Conduit URI).
  • Before: hard fatal with a bad method call.
  • After: non-Conduit exception raised to user. Not ideal, but a step forward.

Diff Detail

Repository
rARC Arcanist
Branch
ex1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24911
Build 34368: Run Core Tests
Build 34367: arc lint + arc unit