Page MenuHomePhabricator

In ConduitCallFuture, only call Conduit exception messages on Conduit exceptions
ClosedPublic

Authored by epriestley on Sep 17 2020, 8:19 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Feb 9, 1:12 AM
Unknown Object (File)
Mon, Feb 3, 2:18 AM
Unknown Object (File)
Mon, Jan 27, 7:42 AM
Unknown Object (File)
Tue, Jan 21, 3:10 PM
Unknown Object (File)
Tue, Jan 21, 12:57 PM
Unknown Object (File)
Fri, Jan 17, 4:18 PM
Unknown Object (File)
Jan 16 2025, 12:59 PM
Unknown Object (File)
Dec 28 2024, 5:19 PM
Subscribers
None

Details

Summary

Ref T13582. When this code is reached with a raw HTTP exception, it currently fatals.

Test Plan
  • Ran arc branches --conduit-uri=http://example.org (a bad Conduit URI).
  • Before: hard fatal with a bad method call.
  • After: non-Conduit exception raised to user. Not ideal, but a step forward.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable