Page MenuHomePhabricator

In ConduitCallFuture, only call Conduit exception messages on Conduit exceptions
ClosedPublic

Authored by epriestley on Sep 17 2020, 8:19 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 25, 1:54 AM
Unknown Object (File)
Wed, Apr 24, 4:28 PM
Unknown Object (File)
Thu, Apr 18, 8:26 AM
Unknown Object (File)
Wed, Apr 17, 8:42 AM
Unknown Object (File)
Sun, Mar 31, 3:40 AM
Unknown Object (File)
Mar 7 2024, 12:42 AM
Unknown Object (File)
Feb 15 2024, 10:30 PM
Unknown Object (File)
Feb 4 2024, 12:28 AM
Subscribers
None

Details

Summary

Ref T13582. When this code is reached with a raw HTTP exception, it currently fatals.

Test Plan
  • Ran arc branches --conduit-uri=http://example.org (a bad Conduit URI).
  • Before: hard fatal with a bad method call.
  • After: non-Conduit exception raised to user. Not ideal, but a step forward.

Diff Detail

Repository
rARC Arcanist
Branch
ex1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24911
Build 34368: Run Core Tests
Build 34367: arc lint + arc unit