Page MenuHomePhabricator

In ConduitCallFuture, only call Conduit exception messages on Conduit exceptions
ClosedPublic

Authored by epriestley on Sep 17 2020, 8:19 PM.
Tags
None
Referenced Files
F13211887: D21467.diff
Fri, May 17, 6:12 AM
F13195545: D21467.diff
Sun, May 12, 10:28 PM
F13178295: D21467.diff
Wed, May 8, 8:19 PM
F13174597: D21467.diff
Wed, May 8, 12:05 AM
Unknown Object (File)
Sun, Apr 28, 10:39 AM
Unknown Object (File)
Thu, Apr 25, 1:54 AM
Unknown Object (File)
Wed, Apr 24, 4:28 PM
Unknown Object (File)
Apr 18 2024, 8:26 AM
Subscribers
None

Details

Summary

Ref T13582. When this code is reached with a raw HTTP exception, it currently fatals.

Test Plan
  • Ran arc branches --conduit-uri=http://example.org (a bad Conduit URI).
  • Before: hard fatal with a bad method call.
  • After: non-Conduit exception raised to user. Not ideal, but a step forward.

Diff Detail

Repository
rARC Arcanist
Branch
ex1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24911
Build 34368: Run Core Tests
Build 34367: arc lint + arc unit