Page MenuHomePhabricator

Add "internal.commit.search" to replace the cache bypass mode of "diffusion.querycommits"
ClosedPublic

Authored by epriestley on Aug 12 2020, 6:41 PM.
Tags
None
Referenced Files
F13184114: D21443.diff
Fri, May 10, 3:27 PM
F13182109: D21443.diff
Thu, May 9, 7:39 PM
F13179645: D21443.diff
Wed, May 8, 9:20 PM
Unknown Object (File)
Mon, May 6, 1:04 AM
Unknown Object (File)
Sat, May 4, 6:55 PM
Unknown Object (File)
Sat, May 4, 1:43 AM
Unknown Object (File)
Wed, May 1, 12:22 AM
Unknown Object (File)
Sat, Apr 27, 3:05 AM
Subscribers
None

Details

Summary

Ref T13552. Commit parsers currently invoke a special mode of "diffusion.querycommits", which is an older frozen method.

The replacement, "diffusion.commit.search", is not really appropriate for low-level access. This mode of having a single method which operates in "cache" or "non-cache" modes also ends up in a lot of unnecessary field shuffling.

Provide "internal.commit.search" as a modern equivalent that returns a "DiffusionCommitRef"-compatible structure.

Test Plan

Executed "internal.commit.search", got sensible low-level commit results.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Sep 16 2020, 12:36 AM
This revision was automatically updated to reflect the committed changes.