Page MenuHomePhabricator

Add "internal.commit.search" to replace the cache bypass mode of "diffusion.querycommits"
ClosedPublic

Authored by epriestley on Aug 12 2020, 6:41 PM.
Tags
None
Referenced Files
F15557028: D21443.id51080.diff
Mon, Apr 28, 7:31 PM
F15553383: D21443.id51042.diff
Mon, Apr 28, 1:46 AM
F15546779: D21443.id.diff
Sat, Apr 26, 4:49 PM
F15543311: D21443.diff
Fri, Apr 25, 9:50 PM
F15501008: D21443.diff
Sun, Apr 13, 8:14 PM
F15492067: D21443.diff
Sat, Apr 12, 10:33 AM
F15488926: D21443.id51080.diff
Fri, Apr 11, 4:20 AM
F15465141: D21443.diff
Wed, Apr 2, 3:10 PM
Subscribers
None

Details

Summary

Ref T13552. Commit parsers currently invoke a special mode of "diffusion.querycommits", which is an older frozen method.

The replacement, "diffusion.commit.search", is not really appropriate for low-level access. This mode of having a single method which operates in "cache" or "non-cache" modes also ends up in a lot of unnecessary field shuffling.

Provide "internal.commit.search" as a modern equivalent that returns a "DiffusionCommitRef"-compatible structure.

Test Plan

Executed "internal.commit.search", got sensible low-level commit results.

Diff Detail

Repository
rP Phabricator
Branch
cref3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24857
Build 34289: Run Core Tests
Build 34288: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Sep 16 2020, 12:36 AM
This revision was automatically updated to reflect the committed changes.