Page MenuHomePhabricator

Add "internal.commit.search" to replace the cache bypass mode of "diffusion.querycommits"
ClosedPublic

Authored by epriestley on Aug 12 2020, 6:41 PM.
Tags
None
Referenced Files
F14090426: D21443.diff
Sun, Nov 24, 5:53 PM
Unknown Object (File)
Thu, Nov 21, 8:41 AM
Unknown Object (File)
Sun, Nov 17, 1:42 PM
Unknown Object (File)
Sun, Nov 17, 10:42 AM
Unknown Object (File)
Sun, Nov 17, 7:39 AM
Unknown Object (File)
Sun, Nov 17, 6:06 AM
Unknown Object (File)
Thu, Nov 7, 2:04 PM
Unknown Object (File)
Oct 19 2024, 12:31 PM
Subscribers
None

Details

Summary

Ref T13552. Commit parsers currently invoke a special mode of "diffusion.querycommits", which is an older frozen method.

The replacement, "diffusion.commit.search", is not really appropriate for low-level access. This mode of having a single method which operates in "cache" or "non-cache" modes also ends up in a lot of unnecessary field shuffling.

Provide "internal.commit.search" as a modern equivalent that returns a "DiffusionCommitRef"-compatible structure.

Test Plan

Executed "internal.commit.search", got sensible low-level commit results.

Diff Detail

Repository
rP Phabricator
Branch
cref3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24857
Build 34289: Run Core Tests
Build 34288: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Sep 16 2020, 12:36 AM
This revision was automatically updated to reflect the committed changes.