Page MenuHomePhabricator

Add "internal.commit.search" to replace the cache bypass mode of "diffusion.querycommits"
ClosedPublic

Authored by epriestley on Aug 12 2020, 6:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 27, 2:01 AM
Unknown Object (File)
Wed, Mar 27, 2:01 AM
Unknown Object (File)
Wed, Mar 27, 2:01 AM
Unknown Object (File)
Wed, Mar 27, 2:01 AM
Unknown Object (File)
Sun, Mar 17, 12:54 PM
Unknown Object (File)
Feb 19 2024, 7:49 AM
Unknown Object (File)
Jan 16 2024, 5:16 PM
Unknown Object (File)
Dec 28 2023, 4:15 AM
Subscribers
None

Details

Summary

Ref T13552. Commit parsers currently invoke a special mode of "diffusion.querycommits", which is an older frozen method.

The replacement, "diffusion.commit.search", is not really appropriate for low-level access. This mode of having a single method which operates in "cache" or "non-cache" modes also ends up in a lot of unnecessary field shuffling.

Provide "internal.commit.search" as a modern equivalent that returns a "DiffusionCommitRef"-compatible structure.

Test Plan

Executed "internal.commit.search", got sensible low-level commit results.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Sep 16 2020, 12:36 AM
This revision was automatically updated to reflect the committed changes.