Paths

Table of Contentst

Fix a missing "pht()" parameter in HTTPSFuture
ClosedPublic
Actions

Authored by epriestley on Sep 5 2020, 12:09 AM.

Tags

None

Referenced Files

	F15506614: D21454.diff
	Tue, Apr 15, 12:43 PM

	F15492484: D21454.diff
	Sat, Apr 12, 2:55 PM

	F15454986: D21454.id51064.diff
	Sat, Mar 29, 9:44 PM

	F15449339: D21454.id51059.diff
	Fri, Mar 28, 9:36 AM

	F15447366: D21454.id.diff
	Thu, Mar 27, 11:22 PM

	F15442934: D21454.diff
	Thu, Mar 27, 1:20 AM

	F15388993: D21454.id.diff
	Mar 15 2025, 4:47 AM

	F15357890: D21454.id51064.diff
	Mar 11 2025, 7:04 AM

View All 82 Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13577: HTTPSFuture has a missing parameter in an exception message when overwriting a download path
Commits: rARC1c327208d7ba: Fix a missing "pht()" parameter in HTTPSFuture

Summary

Ref T13577. This call is missing a parameter. After D21453, this is detected properly by lint. Provide the parameter.

Test Plan

Ran arc lint on HTTPSFuture before and after the change.

Diff Detail

Repository

rARC Arcanist

Branch

linter2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 24874
Build 34317: Run Core Tests
Build 34316: arc lint + arc unit

Event Timeline

epriestley created this revision.Sep 5 2020, 12:09 AM

Harbormaster completed remote builds in B24874: Diff 51059.Sep 5 2020, 12:10 AM

epriestley requested review of this revision.Sep 5 2020, 12:10 AM

epriestley mentioned this in T13577: HTTPSFuture has a missing parameter in an exception message when overwriting a download path.Sep 5 2020, 12:32 AM

This revision was not accepted when it landed; it landed in state Needs Review.Sep 8 2020, 6:46 PM

Closed by commit rARC1c327208d7ba: Fix a missing "pht()" parameter in HTTPSFuture (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARC1c327208d7ba: Fix a missing "pht()" parameter in HTTPSFuture.

Revision Contents
Changeset List

Path

Size

src/

future/

http/

HTTPSFuture.php

5 lines

Diff 51059

View Options

src/future/http/HTTPSFuture.php

Fix a missing "pht()" parameter in HTTPSFutureClosedPublicActions