Paths

Table of Contentst

Differential D21454

Fix a missing "pht()" parameter in HTTPSFuture
ClosedPublic
Actions

Authored by epriestley on Sep 5 2020, 12:09 AM.

Tags

None

Referenced Files

	F13092898: D21454.id51064.diff
	Thu, Apr 25, 6:15 AM

	Unknown Object (File)
	Sun, Apr 21, 6:44 PM

	Unknown Object (File)
	Fri, Apr 19, 6:29 AM

	Unknown Object (File)
	Fri, Mar 29, 3:12 PM

	Unknown Object (File)
	Feb 12 2024, 8:23 AM

	Unknown Object (File)
	Jan 20 2024, 4:38 PM

	Unknown Object (File)
	Jan 16 2024, 5:50 PM

	Unknown Object (File)
	Jan 12 2024, 5:38 PM

View All 49 Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13577: HTTPSFuture has a missing parameter in an exception message when overwriting a download path
Commits: rARC1c327208d7ba: Fix a missing "pht()" parameter in HTTPSFuture

Summary

Ref T13577. This call is missing a parameter. After D21453, this is detected properly by lint. Provide the parameter.

Test Plan

Ran arc lint on HTTPSFuture before and after the change.

Diff Detail

Repository

Branch

linter2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 24874
Build 34317: Run Core Tests
Build 34316: arc lint + arc unit

Event Timeline

epriestley created this revision.Sep 5 2020, 12:09 AM

Harbormaster completed remote builds in B24874: Diff 51059.Sep 5 2020, 12:10 AM

epriestley requested review of this revision.Sep 5 2020, 12:10 AM

epriestley mentioned this in T13577: HTTPSFuture has a missing parameter in an exception message when overwriting a download path.Sep 5 2020, 12:32 AM

This revision was not accepted when it landed; it landed in state Needs Review.Sep 8 2020, 6:46 PM

Closed by commit rARC1c327208d7ba: Fix a missing "pht()" parameter in HTTPSFuture (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARC1c327208d7ba: Fix a missing "pht()" parameter in HTTPSFuture.

Revision Contents
Changeset List

Path

Size

src/

future/

http/

HTTPSFuture.php

5 lines

Diff 51059

src/future/http/HTTPSFuture.php

Loading...