Page MenuHomePhabricator

In Jupyter notebooks, read strings stored in the raw as either "string" or "list<string>" more consistently
ClosedPublic

Authored by epriestley on Aug 5 2020, 7:19 PM.
Tags
None
Referenced Files
F15473401: D21434.id.diff
Sat, Apr 5, 9:44 PM
F15456677: D21434.id51004.diff
Sun, Mar 30, 11:17 AM
F15445577: D21434.diff
Thu, Mar 27, 2:42 PM
F15433472: D21434.id51005.diff
Mon, Mar 24, 11:24 PM
F15426684: D21434.id51005.diff
Sun, Mar 23, 10:27 AM
F15422632: D21434.diff
Sat, Mar 22, 9:52 AM
F15378766: D21434.id51005.diff
Thu, Mar 13, 4:51 PM
F15373301: D21434.id51004.diff
Wed, Mar 12, 3:19 PM
Subscribers
None

Details

Summary

Ref PHI1835. Generally, Jupyter notebooks in the wild may store source and markdown content as either a single string or a list of strings.

Make the renderer read these formats more consistently. In particular, this fixes rendering of code blocks stored as a single string.

This also fixes an issue where cell labels were double-rendered in diff views.

Test Plan

Created a notebook with a code block represented on disk as a single string, rendered a diff from it.

Screen Shot 2020-08-05 at 12.18.44 PM.png (149×1 px, 48 KB)

Diff Detail

Repository
rP Phabricator
Branch
jupyter1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24821
Build 34244: Run Core Tests
Build 34243: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Aug 5 2020, 7:26 PM
This revision was automatically updated to reflect the committed changes.