In Jupyter notebooks, read strings stored in the raw as either "string" or "list<string>" more consistently
ClosedPublic
Actions

Authored by epriestley on Aug 5 2020, 7:19 PM.

Details

Reviewers: None
Commits: rP2db1955159f7: In Jupyter notebooks, read strings stored in the raw as either "string" or…

Summary

Ref PHI1835. Generally, Jupyter notebooks in the wild may store source and markdown content as either a single string or a list of strings.

Make the renderer read these formats more consistently. In particular, this fixes rendering of code blocks stored as a single string.

This also fixes an issue where cell labels were double-rendered in diff views.

Test Plan

Created a notebook with a code block represented on disk as a single string, rendered a diff from it.

Diff Detail

Repository

rP Phabricator

Branch

jupyter1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 24821
Build 34244: Run Core Tests
Build 34243: arc lint + arc unit

Event Timeline

epriestley created this revision.Aug 5 2020, 7:19 PM

Harbormaster completed remote builds in B24821: Diff 51004.Aug 5 2020, 7:20 PM

epriestley requested review of this revision.Aug 5 2020, 7:20 PM

This revision was not accepted when it landed; it landed in state Needs Review.Aug 5 2020, 7:26 PM

Closed by commit rP2db1955159f7: In Jupyter notebooks, read strings stored in the raw as either "string" or… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP2db1955159f7: In Jupyter notebooks, read strings stored in the raw as either "string" or….

Revision Contents
Changeset List

Path

Size

src/

applications/

files/

document/

PhabricatorJupyterDocumentEngine.php

80 lines

Diff 51004

View Options

src/applications/files/document/PhabricatorJupyterDocumentEngine.php

In Jupyter notebooks, read strings stored in the raw as either "string" or "list<string>" more consistentlyClosedPublicActions