Page MenuHomePhabricator

In Jupyter notebooks, read strings stored in the raw as either "string" or "list<string>" more consistently
ClosedPublic

Authored by epriestley on Aug 5 2020, 7:19 PM.
Tags
None
Referenced Files
F17643173: D21434.id51005.diff
Fri, Jul 11, 9:13 PM
F17634880: D21434.id.diff
Fri, Jul 11, 12:04 AM
F17615951: D21434.diff
Wed, Jul 9, 2:31 PM
Unknown Object (File)
Tue, Jul 1, 8:12 AM
Unknown Object (File)
Tue, Jul 1, 8:09 AM
Unknown Object (File)
Mon, Jun 30, 7:48 AM
Unknown Object (File)
Mon, Jun 30, 7:11 AM
Unknown Object (File)
Sun, Jun 29, 5:52 PM
Subscribers
None

Details

Summary

Ref PHI1835. Generally, Jupyter notebooks in the wild may store source and markdown content as either a single string or a list of strings.

Make the renderer read these formats more consistently. In particular, this fixes rendering of code blocks stored as a single string.

This also fixes an issue where cell labels were double-rendered in diff views.

Test Plan

Created a notebook with a code block represented on disk as a single string, rendered a diff from it.

Screen Shot 2020-08-05 at 12.18.44 PM.png (149×1 px, 48 KB)

Diff Detail

Repository
rP Phabricator
Branch
jupyter1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24821
Build 34244: Run Core Tests
Build 34243: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Aug 5 2020, 7:26 PM
This revision was automatically updated to reflect the committed changes.