In 1-up source diffs, retain the "No newline at end of file" on "\" lines
ClosedPublic
Actions

Authored by epriestley on Aug 5 2020, 4:49 PM.

Details

Reviewers: None
Commits: rP98e0440d459b: In 1-up source diffs, retain the "No newline at end of file" on "\" lines

Summary

See PHI1839. Currently, the "No newline at end of file" text is dropped in the 1-up diff view for changes that affect a file with no trailing newline.

Track it through the construction of diff primitivies more carefully.

Test Plan

Screen Shot 2020-08-05 at 9.43.24 AM.png (549×327 px, 35 KB)

Diff Detail

Repository

rP Phabricator

Branch

newline1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 24819
Build 34241: Run Core Tests
Build 34240: arc lint + arc unit

Event Timeline

epriestley created this revision.Aug 5 2020, 4:49 PM

Harbormaster completed remote builds in B24819: Diff 51002.Aug 5 2020, 4:50 PM

epriestley requested review of this revision.Aug 5 2020, 4:50 PM

epriestley mentioned this in T13557: Unified diffs could do a better job of rendering omitted trailing newlines.Aug 5 2020, 5:07 PM

This revision was not accepted when it landed; it landed in state Needs Review.Aug 5 2020, 5:17 PM

Closed by commit rP98e0440d459b: In 1-up source diffs, retain the "No newline at end of file" on "\" lines (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP98e0440d459b: In 1-up source diffs, retain the "No newline at end of file" on "\" lines.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

render/

DifferentialChangesetOneUpRenderer.php

8 lines

DifferentialChangesetRenderer.php

4 lines

Diff 51002

View Options

src/applications/differential/render/DifferentialChangesetOneUpRenderer.php