Page MenuHomePhabricator

In 1-up source diffs, retain the "No newline at end of file" on "\" lines
ClosedPublic

Authored by epriestley on Aug 5 2020, 4:49 PM.

Details

Summary

See PHI1839. Currently, the "No newline at end of file" text is dropped in the 1-up diff view for changes that affect a file with no trailing newline.

Track it through the construction of diff primitivies more carefully.

Test Plan

Screen Shot 2020-08-05 at 9.43.24 AM.png (549×327 px, 35 KB)

Diff Detail

Repository
rP Phabricator
Branch
newline1
Lint
Lint OK
Unit
Unit Tests OK
Build Status
Buildable 24819
Build 34241: Run Core Tests
Build 34240: arc lint + arc unit