Ref T13555. Although these callsites may not actually impact anything, it's possible for an active handle to have no PID (e.g., if the subprocess failed to start).
Handle these cases more carefully.
Details
Details
- Reviewers
- None
- Maniphest Tasks
- T13555: In "ExecFuture", "proc_get_status()" may be passed NULL, possibly leading to a daemon stall
- Commits
- rP5f0535934d72: Manage PIDs more carefully in DaemonHandle
Started daemons, saw them run fine. See also next change.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- pid1
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 24795 Build 34206: Run Core Tests Build 34205: arc lint + arc unit