Manage PIDs more carefully in DaemonHandle
ClosedPublic
Actions

Authored by epriestley on Jul 23 2020, 5:09 PM.

Details

Reviewers: None
Maniphest Tasks: T13555: In "ExecFuture", "proc_get_status()" may be passed NULL, possibly leading to a daemon stall
Commits: rP5f0535934d72: Manage PIDs more carefully in DaemonHandle

Summary

Ref T13555. Although these callsites may not actually impact anything, it's possible for an active handle to have no PID (e.g., if the subprocess failed to start).

Handle these cases more carefully.

Test Plan

Started daemons, saw them run fine. See also next change.

Diff Detail

Repository

rP Phabricator

Branch

pid1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 24795
Build 34206: Run Core Tests
Build 34205: arc lint + arc unit

Event Timeline

epriestley created this revision.Jul 23 2020, 5:09 PM

Harbormaster completed remote builds in B24795: Diff 50975.Jul 23 2020, 5:10 PM

epriestley requested review of this revision.Jul 23 2020, 5:10 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jul 23 2020, 6:22 PM

Closed by commit rP5f0535934d72: Manage PIDs more carefully in DaemonHandle (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP5f0535934d72: Manage PIDs more carefully in DaemonHandle.

Revision Contents
Changeset List

Path

Size

src/

infrastructure/

daemon/

PhutilDaemonHandle.php

25 lines

Diff 50975

View Options

src/infrastructure/daemon/PhutilDaemonHandle.php

Manage PIDs more carefully in DaemonHandleClosedPublicActions