Page MenuHomePhabricator

Manage PIDs more carefully in DaemonHandle
ClosedPublic

Authored by epriestley on Jul 23 2020, 5:09 PM.

Details

Summary

Ref T13555. Although these callsites may not actually impact anything, it's possible for an active handle to have no PID (e.g., if the subprocess failed to start).

Handle these cases more carefully.

Test Plan

Started daemons, saw them run fine. See also next change.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Jul 23 2020, 6:22 PM
This revision was automatically updated to reflect the committed changes.